Ubuntu
open-iscsi package

Code review comment for ~rafaeldtinoco/ubuntu/+source/open-iscsi:lp1892228-groovy

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/open-iscsi
  3. lp1892228-groovy
  4. Merge into lp1891374-groovy
Revision history for this message
Bryce Harrington (bryce) wrote :

Yep, makes sense on the binary package name.

The fix for the deprecated warning is correct, but I suggest a bit more wording in the changelog entry to explain what's going on:

With that changelog entry fix, LGTM for upload.

review: Approve

« Back to merge proposal