Ubuntu
ndctl package

Code review comment for ~rafaeldtinoco/ubuntu/+source/ndctl:lp1811785-bionic

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/ndctl
  3. lp1811785-bionic
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I think the fix itself is good, but a few things need cleanup.

changelog: we usually name the patch before the colon:
so instead
     * ndctl/init-labels: Fix label slot accounting per UEFI 2.7 (LP: #1811785)
maybe:
     * d/p/ndctl-init-labels-Fix-label-slot-accounting-per-UEFI.patch: Fix label slot accounting per UEFI 2.7 (LP: #1811785)

Furthermore the bug should get a proper SRU Template before sponsoring it into -unapproved.

review: Needs Fixing

« Back to merge proposal