Ubuntu
libvirt package

Code review comment for ~rafaeldtinoco/ubuntu/+source/libvirt:focal-clustersize

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/libvirt
  3. focal-clustersize
  4. Merge into ubuntu/focal-devel
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

The real problem is that a virsh vol-dumpxml is including a:

<source>
</source>

at the final XML, which causes no harm but the test compares with given output (brought by my set) and says its wrong. The backport is good and works.

This behaviour is fixed by:

commit 6423e30828
Author: Peter Krempa <email address hidden>
Date: Thu Feb 25 10:11:05 2021

    virStorageVolDefFormat: Don't format empty <source>

    If there are no source extents the volume XML has an empty <source>
    element. Remove it if there's nothing in it by using
    virXMLFormatElement.

    Signed-off-by: Peter Krempa <email address hidden>
    Reviewed-by: Michal Privoznik <email address hidden>

but if bringing this patch before my patchset ... other tests break and I dont want to go deep into why previous tests are being broken by this.

Previous attempt I tried to include <source></source> in the XML and it worked for my local builds, when test would compare the output of the vol-dumpxml sub-command it would find a local file exactly the same as expected.

I'm afraid I did not test with all other patches included, that is why its failing in dpkg-buildpackage. Being in hurry is enemy of perfection, as usually said.

I'm fixing this now and will make sure it works for the dpkg-buildpackage of both focal and bionic.

Reply

« Back to merge proposal