Code review comment for ~rafaeldtinoco/ubuntu/+source/ipxe:ipxe-focal-merge

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The code of Alkis LGTM but it is complex, therefore I asked you to test it a while a go and that all looked good.
Therefore +1 to that part.

The ipxe id is a small, but helpful change for our users.
I double checked https://www.gnu.org/software/grub/manual/grub/grub.html#menuentry for side effects but I think it is useful and has no drawback.

ack to both parts of this.

« Back to merge proposal