Ubuntu
iproute2 package

Code review comment for ~rafaeldtinoco/ubuntu/+source/iproute2:lp1831775-cosmic-sru-iproute2

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/iproute2
  3. lp1831775-cosmic-sru-iproute2
  4. Merge into ubuntu/cosmic-proposed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, some comments inline, and below.

For SRUs, the merge target should always be ubuntu/<release>-devel.

Can you elaborate a bit more on the test case you added to the bug? Like, what to expect in the broken and in the good cases. Ideally it should be as simple as just copying and pasting something in the command line, but it's fine if it needs some setting up. For example, "create a connection from A to B, note the IPs used, and use the IPs in the following command."

I saw you added some test results further down in the bug, but for the SRU template, it's best if all that's needed to verify the bug is fixed is in the "opening salvo".

In "regression potential", you say " * ss interpreter (bison powered) could be broken". What does that mean? Why do you think it could be broken? These are questions the SRU team would probably ask. "ip" is used all over the place, and it's good to detail what are your thoughts on possible regressions.

review: Needs Fixing

« Back to merge proposal