Merge lp:~radonapps/messaging-app/fix_swipe-demo_text_position into lp:messaging-app
Proposed by
Daniyaal Rasheed
Status: | Merged |
---|---|
Merged at revision: | 517 |
Proposed branch: | lp:~radonapps/messaging-app/fix_swipe-demo_text_position |
Merge into: | lp:messaging-app |
Diff against target: |
23 lines (+2/-3) 1 file modified
src/qml/SwipeItemDemo.qml (+2/-3) |
To merge this branch: | bzr merge lp:~radonapps/messaging-app/fix_swipe-demo_text_position |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tiago Salem Herrmann | Pending | ||
Review via email: mp+283254@code.launchpad.net |
Commit message
Makes text in the swipe demo use relative positioning instead of absolute.
Description of the change
I've deleted the absolute height specification inside of the RowLayout so that the height of the message is entirely dependent on the height of the dragMessage. The "Got it" button is anchored to the bottom of the message because if it was anchored to the top, then it would jump around whenever the number of lines in the text increased or decreased. Then I changed the bottomMargin of the "Got it" button to be units.gu(21) instead of 19 because the message row layout used to have a height of 3 and the button was anchored to its top instead of bottom.
To post a comment you must log in.
Hi,
Could you please merge trunk back into your branch?
We need it to be up-to-date in order to land it.
Thanks.