Code review comment for lp:~radix/landscape-client/fix-landscape-client-startup

+1, looks good!

#1:
+def get_component_registry():
+ return {
+ "broker": RemoteBrokerConnector,
+ "client": RemoteClientConnector,
+ "monitor": RemoteMonitorConnector,
+ "manager": RemoteManagerConnector
+ }

You could write this as

+COMPONENTS = [
+ RemoteBrokerConnector, RemoteClientConnector, RemoteMonitorConnector, RemoteManagerConnector]
+
+def get_component_registry():
+ return dict(
+ (connector_class.component.name, connector_class)
+ for connector_class in COMPONENTS)

#2:
landscape/broker/server.py:305:1: W391 blank line at end of file