Code review comment for lp:~rackspace-titan/nova/postgres-instance-type-id

Revision history for this message
Rick Harris (rconradharris) wrote :

Looks great.

Tested upgrade and downgrade paths with good and bad data. All worked as expected.

Just a thought:

Would it be useful to log at the error-level any instances that weren't properly converted over, e.g.

  LOG.error("Instance %s did not have instance_type_id converted to an int because its value is" % (instance.id, instance.instance_type_id))

review: Approve

« Back to merge proposal