Code review comment for lp:~rackspace-titan/nova/osapi-pass-update-lp744567
Revision history for this message
| Brian Waldon (bcwaldon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
> Is the "isinstance(name, basestring)" needed or can you just cast the name to
> a string? When would it not be a string?
I typically operate under the assumption that the users of the api will make mistakes. Would it make sense to cast a dict as the server name? It would be easily correctable, but should we prevent it from happening in the first place? The v1.1 spec doesn't seem to offer any help.