Code review comment for lp:~rackspace-titan/nova/minram-mindisk

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Can you change the new exception names to InstanceTypeDiskTooSmall and InstanceTypeMemoryTooSmall? I think keeping the term 'flavor' limited to the OSAPI view is a good thing to do here.

It looks like we only test passing image filters through to the image service, not that the image service actually does something with them. If you see a way we can test that, I would love to see it :) It's not a blocker for my Approve, though.

review: Needs Fixing

« Back to merge proposal