Code review comment for lp:~rackspace-titan/nova/metadata_v1.1

Revision history for this message
Matt Dietz (cerberus) wrote :

Your database API method names aren't consistent with the rest of the DB API

159 +def delete_instance_metadata(context, instance_id, key):

Should be, for example:

159 +def instance_metadata_delete(context, instance_id, key):

With that said, I actually have reservations about whether or not this branch truly belongs in Nova. It seems like it would be better situated in a metadata service somewhere at the top of the stack, possibly attached to the API, and simply mapped to instance_ids.

Since I missed this spec originally I won't block it, but I'd like to maybe discuss moving the responsibility for this to a different layer post Cactus

review: Needs Fixing

« Back to merge proposal