Code review comment for lp:~rackspace-titan/nova/instance_states

Revision history for this message
Brian Lamar (blamar) wrote :

> This is absolutely incredible. You've done a great job, here. One general
> comment before the line-by-line stuff:
>
> Can we align the states with respect to tense? I don't think all of our states
> need to end in ING or ED. What do you think?

The original design had all vm_states and task_states in the same tenses. No INGs or EDs.

task_states.SCHEDULE just didn't have the same effect on me as task_states.SCHEDULING but really it's not a huge difference in my mind. We're just a few seds away from changing everything so it's not difficult. Some of them get more confusing IMO without ING or ED:

NETWORK vs NETWORKING
PAUSE vs PAUSED
STOP vs STOPPED

Would you recommend unification of tenses or just removal of all ING/ED/tense?

« Back to merge proposal