Code review comment for lp:~rackspace-titan/nova/empty-network-lp835242
Revision history for this message
| Brian Waldon (bcwaldon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> LGTM. Curiosity:
>
> 7 except (TypeError, KeyError) as exc:
> 8 - LOG.exception(exc)
> 9 raise TypeError
>
> Why are we catching and reraising a different exception?
Since I wrote it, I'll answer: I didn't want to create a new exception, and it didn't matter if it was a KeyError or a TypeError in the calling code. I will admit it's kind of fragile.