Code review comment for lp:~rackspace-titan/glance/glance-cli-filters
Revision history for this message
| Jay Pipes (jaypipes) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On Mon, Jun 20, 2011 at 5:42 PM, Brian Waldon
<email address hidden> wrote:
>> Is there any reason that 'SUPPORTED_FILTERS' (line 16) is all caps? Usually
>> that style is only for constants that are defined in one place and used in
>> another.
>
> As far as I can tell, it isn't modified. It matches capitalization in other sections of the code, as well. Would you prefer I change it?
No, please leave it. It's a constant. :)
-jay