Code review comment for lp:~rackspace-titan/glance/api-results-filtering

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> Hey Brian,
>
> Excellent work overall. Just one thing to note, though...
>
> 34 + """Return a dictionary of query param filters from the request
> 35 +
> 36 + :param req: the Request object coming from the wsgi layer
>
> In Glance, much of the code uses the docstring style:
>
> """
> Return a dictionary of query param filters from the request
>
> :param req: the Request object coming from the wsgi layer
> ...
> """
>
> Feel free to use it too if you prefer it. ;) I personally can't stand the Nova
> style, as I think it makes things harder to read.
>
> -jay

Made the change. I do prefer your style, and typically keep with whatever style is already established in the file. I guess I was in nova-mode.

« Back to merge proposal