Code review comment for ~racb/uvtool:python3-packaging

Revision history for this message
Robie Basak (racb) wrote :

On Wed, Oct 23, 2019 at 11:20:54AM -0000, Christian Ehrhardt  wrote:
> I didn't expect you to need an explicit --buildsystem=pybuild, but it is ok.

I am under the impression that --buildsystem=pybuild is necessary
currently because it is the recommended best practice but not the
debhelper default.

> Packaging changes pull in quite some old changelogs that are correct, but not part of this merge.
> But it matches what is in Eoan, so that should be fine as well.

I think that's a problem with the preview diff. I think the actual
commits are correct and don't include any unnecessary changes.

> Was that the base for the test PPA that we already tested or do you want testing again?

I updated ppa:racb/experimental2 for Eoan (only) with essentially the
same changes. The only differences are that this branch is rebased on to
my merge into master, rather than my development Python 3 branch, I
dropped uvtool-coverage, and the changelog is different.

If you'd like to see the changes, I have been tagging previous versions
of the packaging branch and pushing those tags - see
python3-packaging/v* in my repo.

I'm confident that it isn't necessary to test further, but if you'd like
to, then please do :)

« Back to merge proposal