Merge lp:~racb/ubuntu/precise/cobbler/858860 into lp:ubuntu/precise/cobbler

Proposed by Robie Basak
Status: Merged
Merged at revision: 68
Proposed branch: lp:~racb/ubuntu/precise/cobbler/858860
Merge into: lp:ubuntu/precise/cobbler
Diff against target: 34 lines (+22/-0)
2 files modified
debian/changelog (+7/-0)
debian/cobbler.preinst (+15/-0)
To merge this branch: bzr merge lp:~racb/ubuntu/precise/cobbler/858860
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Alex Muntada (community) Approve
Review via email: mp+87508@code.launchpad.net

Description of the change

I have upgrade tested this from Oneiric and previous Precise and also tested a fresh installation on Precise.

This is also needed for the security fix in Oneiric - see https://bugs.launchpad.net/ubuntu/+source/cobbler/+bug/858878/comments/5

To post a comment you must log in.
Revision history for this message
Alex Muntada (alex.muntada) wrote :

Change proposed addresses both new installs and upgrades as requested.

review: Approve
68. By Robie Basak

debian/cobbler.preinst: fix /etc/cobbler/users.digest if upgrading from a
version that set it world readable (LP: #858860).

Revision history for this message
Robie Basak (racb) wrote :

Rebased against latest trunk.

Revision history for this message
Alex Muntada (alex.muntada) wrote :

Rebase approved, too.

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

Thanks for the review, Alex! I've just added Andres as he has upload access.

69. By Robie Basak

Remove inadvertent change to debian/cobbler-ubuntu-import

Revision history for this message
Andres Rodriguez (andreserl) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-01-04 14:23:54 +0000
3+++ debian/changelog 2012-01-05 13:31:19 +0000
4@@ -1,3 +1,10 @@
5+cobbler (2.2.2-0ubuntu14) precise; urgency=low
6+
7+ * debian/cobbler.preinst: fix /etc/cobbler/users.digest if upgrading from a
8+ version that set it world readable (LP: #858860).
9+
10+ -- Robie Basak <robie.basak@ubuntu.com> Thu, 05 Jan 2012 09:13:13 +0000
11+
12 cobbler (2.2.2-0ubuntu13) precise; urgency=low
13
14 * debian/patches/62_profile_hostname_no_underscore.patch: Replace
15
16=== added file 'debian/cobbler.preinst'
17--- debian/cobbler.preinst 1970-01-01 00:00:00 +0000
18+++ debian/cobbler.preinst 2012-01-05 13:31:19 +0000
19@@ -0,0 +1,15 @@
20+#!/bin/sh
21+set -e
22+
23+# Fix world-readable permissions on /etc/cobbler/users.digest if upgrading
24+# from a version which had it set incorrectly by default, the file is still
25+# there and still has the original incorrect permissions (LP: #858860).
26+
27+if [ "$1" = "upgrade" ] \
28+ && dpkg --compare-versions "$2" lt "2.2.2-0ubuntu14" \
29+ && [ -f /etc/cobbler/users.digest \
30+ -a `stat -c%a /etc/cobbler/users.digest` = "644" ]; then
31+ chmod 600 /etc/cobbler/users.digest
32+fi
33+
34+#DEBHELPER#

Subscribers

People subscribed via source and target branches

to all changes: