Ubuntu
fence-agents package

Code review comment for ~racb/ubuntu/+source/fence-agents:azure-sdk-15

  1. Git
  2. lp:~racb/ubuntu/+source/fence-agents
  3. azure-sdk-15
  4. Merge into ubuntu/jammy-devel
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I did not test the fence agent itself but I guess Robie did it. Going through the patch, it looks sane to me. I noticed part of this patch is also a backport of this other upstream commit:

https://github.com/ClusterLabs/fence-agents/commit/cb1ff52c14451482dc1faf9aa660a8c525097f94

Maybe it is a good idea to also mention it in the DEP-3 headers for future reference.

Other than that LGTM.

review: Approve

« Back to merge proposal