~racb/git-ubuntu:versioning-revert

Branch merges

Propose for merging

Merged into git-ubuntu:master at revision bec07934deafc4fc217018db65f3bbbb3d46e4b2

Nish Aravamudan: Approve on 2017-07-26

Diff: 107 lines (+14/-25)

1 file modified

gitubuntu/versioning.py (+14/-25)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

bec0793... by Robie Basak on 2017-07-26

versioning: revert series related changes

This regressed tests.

Now we're back where we started. Tests pass for versions calculations
that we had working. The test for the SRU "same version in multiple
series" versioning exception fails as expected, and we're in a position
to be able to implement it.

0fd4f3e... by Robie Basak on 2017-07-26

versioning: import the name Version

This is much simpler than the really obtuse fully qualified name. I know
I usually don't like doing this, but in this case (frequent use, obtuse
otherwise) I think it's worth it. We only use one type of Version object
in this module so this should cause minimal confusion.

b5d0214... by Robie Basak on 2017-07-25

lint: correctly report lint failures on failures

We haven't agreed the best pattern to use for this yet. But currently
the return value of GitUbuntuLint.do_change_lint() is outright wrong,
returning only the status of the final check instead of all the checks
processed.

Fix this, at least for now, by correctly combining the results.

4d59fc3... by Robie Basak on 2017-07-25

lint: fix SRU version check

In the case that a proposed SRU is the first update for a given stable
series, the previous changelog entry will list a Debian codename such as
"unstable". versioning.next_sru_version against "unstable" has no
meaning. The call to it failed with a StopIteration when
GitUbuntuLint._next_sru_version() tried to find a matching Ubuntu series
object in Launchpad called "unstable".

Instead, ditch GitUbuntuLint._next_sru_version() and just use the series
derived from the debian/changelog target to determine which series the
proposer is targeting for the SRU. versioning.next_sru_version will look
the appropriate current series' versions from Launchpad to determine the
answer, so there is no need for us to do it.

43c4271... by Nish Aravamudan on 2017-07-21

git ubuntu lint: drop stray change

I accidentally introduced this in my last bugfix.

640bcda... by Nish Aravamudan on 2017-07-20

git ubuntu lint: properly support --lint-namespace

b9e67b5... by Nish Aravamudan on 2017-07-19

git ubuntu queue: fix GitUbuntuRepository accessor usage

dbbc4a9... by Nish Aravamudan on 2017-07-19

git ubuntu lint: rename mc_treeish to base_treeish

533abd6... by Nish Aravamudan on 2017-07-19

git ubuntu merge: fix error logging

5bcabc8... by Nish Aravamudan on 2017-07-18

git ubuntu clone: provide inline guidance for requesting an import

LP: #1704944