~racb/git-ubuntu:style-on-imports

Last commit made on 2019-12-06
Get this branch:
git clone -b style-on-imports https://git.launchpad.net/~racb/git-ubuntu
Only Robie Basak can upload to this branch. If you are Robie Basak please log in for upload directions.

Branch merges

Branch information

Name:
style-on-imports
Repository:
lp:~racb/git-ubuntu

Recent commits

0693d94... by Robie Basak

Add style convention on import statements

This is what we've been following anyway, but without explicit
documentation.

9e8e5da... by Andreas Hasenack

Add pyzmq to the source whitelist

d4202e3... by Rafael David Tinoco

Add libslirp to whitelist.

MIR underway, requested by cpaelzer.

420b2d2... by Bryce Harrington

Cleanup --help output formatting and show all available commands

Show all of the available subcommands instead of an incomplete subset.
Some commands may be experimental or only relevant for certain subcases,
but it's probably better that these cases are identified and documented
rather than hidden.

The formatting of the text is also improved. argparser was indenting
the subcommands, treating them as content body for the <command>
positional argument. This was indenting too far to the left, making it
look strange. Instead, just move this text into argparser's epilog and
handle indentation ourselves.

LP: #1774330

d57ddb7... by Bryce Harrington

doc: Define a release process

a4e2530... by Bryce Harrington

version: bump to 0.8.0

d358c19... by Robie Basak

Add pandas to whitelist

Requested by mwhudson

2fe7dd5... by Bryce Harrington

setup.py: Bump lazr.restfulclient version requirement

Originally, commit 80c3e0b5 specified this to 0.13.5, and commit
9557cf90 bumped it to 0.14.0. But bionic is currently shipping 0.14.2
and this is what pip has been pulling in during jenkins builds, so
update the requirement to match what's actually been in use.

This fixes an issue caught in the recent addition of `pip3 check` to
git-ubuntu-self-test, where the versions were mis-matched.

    gitubuntu 0.7.4 has requirement lazr.restfulclient==0.14.0, but you have lazr.restfulclient 0.14.2.

e467b42... by Bryce Harrington

setup.py: Bump keyring version for upstream fix

keyring was intended to be pinned to < 16.0.0 due to a regression in
that release that prevented the plaintext keyring from being retrieved.
This was reported upstream[1], and was fixed in a subsequent 16.0.1
release.

Despite this intended pinning, git-ubuntu's snap builds are using a
newer version, 19.2.0, which `pip3 check` is now catching:

  + uvt-kvm ssh --insecure gitubuntu-ci-389 -- bash -l -c git-ubuntu.self-test
  gitubuntu 0.7.4 has requirement keyring<16, but you have keyring 19.2.0.

The inconsistency can be resolved by just requiring 16.0.1 or newer for
the keyring package. Since we're already installing a much newer
version this should cause no behavioral change except to pass the test.

1: https://github.com/jaraco/keyring/issues/357

68d4df7... by Bryce Harrington

Cleanup obsolete integration test code

Prior to the introduction of git-ubuntu-self-test, bin/integration-test
served as a testsuite runner, and tox was used for some style checks.
These are no longer invoked in the jenkins runs[1,2] and thus are just
vestigial now. In fact bin/integration-test no longer works since it
calls `git-ubuntu` rather than `git ubuntu`; functionally it's just a
smoke test like the one documented in the README.md already. To avoid
future confusion, just drop these two old bits.

1: https://github.com/CanonicalLtd/server-jenkins-jobs/commit/c274cdeeae011239d43bf0f0614d4962e2fc1512#diff-34ec3218571d21188aa4d4c163d06408
2: https://github.com/CanonicalLtd/server-jenkins-jobs/commit/48941f90af340156a1cd423c9779d0a03dd2d458#diff-34ec3218571d21188aa4d4c163d06408