Asking the worker for --no-push enables a deeper dry run for performance
testing purposes. Unlike the behaviour of "git ubuntu import", "push
mode" is the default here because normally when one sets up the importer
service, it would be surprising behaviour not to do this, and this is
the only use case for this command.
git ubuntu import has two uses: 1) it's run by the importer service
workers, which should push by default; 2) it's run by users, for whom it
doesn't generally make sense to push by default.
Since it's easy for importer service workers to specify an option by
automation, we flip the default of the CLI to explicitly require --push
if you want to push. This makes it safer and easier to explain to users
how to use the import command locally.
The importer service worker then adds --push unconditionally.
This makes the "implied no push" behaviour of certain options redundant,
so those are removed.
Instead of passing around an inverse boolean "no_push" argument, pass
the more natural "push" instead.
This should make no functional change, but prepares us to invert the CLI
argument since after that future change passing around an inverse
boolean will make even less sense.
Since the normal operation is to push, and straight after that we
"return 0", it's simpler to immediately "return 0" if we don't want to
push. This stops the usual code path being pushed "to the right", and
makes it easier to follow the logic.
This is a followup to commits 57e5776, 002e452, 2f0e855 and 5aad111 with
further cleanups around the project rename from usd-importer to
git-ubuntu and the move to the <email address hidden>
mailing list. Thanks to Bryce for spotting some of the remaining pieces.
Where code is no longer used at all, or docs are completely out-of-date,
I've removed it instead of renaming the relevant bits. I've not worried
too much about fixing docs that I've touched if there's some value to
them staying, as that's a bit of a rabbit hole and I'd prefer to make
incremental progress.
On the Canonical Server Team, we have been using ~canonical-server in
its own review slot for the sole purpose of gathering all reviews we're
interested in tracking together on this team's +activereviews page.
A problem with this is that we all belong to this team, so when a person
does a review, they sometimes accidentally "grab" that slot, so it
appears as their name rather than the team's, and thus disappears from
the report.
One way around this is to use a separate team that none of us actually
belong to. This way we can't "grab" that slot.
This changes the default team to this new ~canonical-server-reporter
team to help those who use the "git ubuntu submit" command.
