~racb/git-ubuntu:nacc-breakdown/gbp-pbuilder-qemubuilder

Last commit made on 2018-01-18
Get this branch:
git clone -b nacc-breakdown/gbp-pbuilder-qemubuilder https://git.launchpad.net/~racb/git-ubuntu
Only Robie Basak can upload to this branch. If you are Robie Basak please log in for upload directions.

Branch merges

Branch information

Name:
nacc-breakdown/gbp-pbuilder-qemubuilder
Repository:
lp:~racb/git-ubuntu

Recent commits

0200711... by Nish Aravamudan

gbp: do not use pbuilder or qemubuilder

e094d56... by Christian Ehrhardt 

add collectd to whitelist

Signed-off-by: Christian Ehrhardt <email address hidden>

35a2b40... by Christian Ehrhardt 

add ubuntu-fan to whitelist

Signed-off-by: Christian Ehrhardt <email address hidden>

967f050... by Robie Basak

Merge remote-tracking branch 'paelzer/add-ubuntu-desktop-sniff-packages' into HEAD

52a4b3f... by Nish Aravamudan

lint: properly pass arguments to do_lint by keyword

They were passed in the wrong order before.

LP: #1735744.

57ca3bd... by Robie Basak

Fix read_timestamps()

This fails hard in the dictionary comprehension over timestamps since it
expects tuples of items instead of a list of keys. Use items() to
correctly provide the former.

f69cbb6... by Robie Basak

Correctly append '.new' to filename for rename

FileNotFoundError: [Errno 2] No such file or directory:
'/tmp/import-source-packages-log/.new'

Expected: '/tmp/import-source-packages-log.new'.

This should be a simple append rather than an os.path.join. Sorry I
missed this in my review.

e7002be... by Robie Basak

Add quilt env handling tests

f7a28df... by Robie Basak

Log applied import error traceback on exception

As we're swallowing the error in a catch-all exception handler here,
it's helpful if we at least log the full exception and traceback.

I've also filed LP 1734349 to see if this could be improved (I'm not
sure).

71d7004... by Robie Basak

import_patches_applied_tree: use correct quilt env

When quilt runs, we must use GitUbuntuRepository:quilt_env in order to
make sure that QUILT_* environment variables are set correctly.
Otherwise we rely on the importer runner having the correct quilt
environment set, which may not be the case.

Also see LP 1734137: separately we need to ensure that any /etc/quiltrc
or ~/.quiltrc is ignored correctly, but I'm treating that as a separate
bug as it needs a more significant refactor to wrap all quilt calls. We
should fix that bug before declaring hash stability, but it isn't as
important as this fix as that one is less likely to be a problem in
practice on our production importer.