~racb/git-ubuntu:multiple-angle-brackets

Branch merges

Propose for merging

Merged into git-ubuntu:master at revision fe87efa8257566c921025a13a0496148a4a185c7

Bryce Harrington: Approve on 2020-08-04

Server Team CI bot: Approve (continuous-integration) on 2020-08-04

Diff: 42 lines (+13/-1)

3 files modified

gitubuntu/changelog_tests/test_multiple_angle_brackets (+6/-0)
gitubuntu/git_repository.py (+1/-1)
gitubuntu/git_repository_test.py (+6/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

1f39102... by Robie Basak on 2020-08-04

Fix extra angle bracket parsing

RFCs 5321/5322/6531 make it clear that an angle bracket is not a valid
part of an email address, so we can correctly parse extra ones as not
being part of the email address.

This requires making the '.*' capture of the email address non-greedy by
appending a '?', so that the greedy '<+' and '>+' can grab the angle
brackets during the regexp match.

3cfb48a... by Robie Basak on 2020-08-04

Add test case for extra angle bracket parsing

In puppet 0.24.4-6, the changelog entry has an extra closing angle
bracket around the email address in the sign-off line. As an angle
bracket is unambiguously not part of the email address (according to
RFCs 5321/5322/6531), this can still be unambiguously parsed, so we add
a failing test case for it to be fixed in a subsequent change.

2e773a1... by Robie Basak on 2020-08-03

Merge branch 'poller-logging'

d6eb8c2... by Robie Basak on 2020-08-03

Merge branch 'empty-changelog-author'

1f3fc58... by Robie Basak on 2020-08-03

Merge branch 'importer-notes-newline'

9222c0d... by Robie Basak on 2020-07-23

Handle empty changelog author names

git (or at least pygit2) won't accept an author name that is empty, so
we must use some placeholder instead. I have adjusted the spec for this
to be 'Unnamed', and behaviour and the existing test case is adjusted
here accordingly.

This shouldn't cause "hash-abi-break" because the importer was failing
on such cases previously. None of the known cases (detailed in the spec)
had been successfully imported previously.

05b7213... by Robie Basak on 2020-07-31

poller: log package count after startup

We had a case where it seemed that the poller wasn't picking up on the
complete list of packages to import. To assist debugging of this if it
happens again, log the number of packages marked importable after this
list is determined at startup.

b623e27... by Robie Basak on 2020-07-28

Remove temporary blacklist of fixed packages

These packages have all been reimported successfully and no longer need
manual intervention, so can be restored to normal operation.

e2212c1... by Andreas Hasenack on 2020-07-24

Import golang-github-pkg-errors

ad12f57... by Rafael David Tinoco on 2020-07-24

Import python-configshell-fb (targetcli-fb MIR)