~racb/git-ubuntu:keyring-backend-fix

Last commit made on 2018-09-28
Get this branch:
git clone -b keyring-backend-fix https://git.launchpad.net/~racb/git-ubuntu
Only Robie Basak can upload to this branch. If you are Robie Basak please log in for upload directions.

Branch merges

Branch information

Name:
keyring-backend-fix
Repository:
lp:~racb/git-ubuntu

Recent commits

4fe8482... by Robie Basak

Drop keyrings.alt version restriction

The launchpadlib part requires "keyring" with no version restriction. By
requiring a particular version here, we're relying that some newest
version of keyring will work with this particular keyrings.alt, which
fails with keyring 15.0.0 vs. keyrings.alt 2.3. Since launchpadlib
already has no version restriction, do the same for keyrings.alt. Then
at least if "pip3 install" works, so should the snap.

Alternatively we could have added a version restriction to the
launchpadlib part, but at the moment that pattern isn't used anywhere,
and the requirements are taken from launchpadlib's setup.py with no
patching. If we want to restrict versions some other way, then we'll
need a major reworking of how the snap is put together.

Now the test checking that keyring can find a functional backend should
always pass.

LP: #1794041

88e5640... by Robie Basak

Test that a keyring backend can be found

LP: #1794041

773bc06... by Robie Basak

Add rustc to whitelist

cbb0f52... by Robie Basak

tag: improve dirty tree detection

If raw_repo.status() returns entries that are GIT_STATUS_IGNORED then
they don't represent the tree being dirty, so ignore this case. This
fixes a case where "git ubuntu tag" refuses to work even when a working
tree is clean.

Related bugs:

https://bugs.launchpad.net/usd-importer/+bug/1687940
https://bugs.launchpad.net/usd-importer/+bug/1739000

75adf7d... by Robie Basak

Merge branch 'bugfix/move_sources_out_of_snap_dir' of git+ssh://git.launchpad.net/~kyrofa/usd-importer

2a5b1ed... by Robie Basak

wip: fix whitespace wrap

7728112... by Scott Moser

Change internal user to 'buildd' from build-user.

This is same user as launchpad.
The path under the user's home (~/build) is left the same.
On launchpad the path is something like build-PACKAGEBUILD-XXXXXXX
but that seems less useful than a constant path for a user
using '--keep'.

7d9b563... by Kyle Fazzari

Place wrappers back into wrappers subdirectory

Signed-off-by: Kyle Fazzari <email address hidden>

fa40cb0... by Scott Moser

Fix 'git ubuntu build' when user id does not match container id.

If the user running 'git ubuntu build' did not have the same user-id
as the user 'ubuntu' inside the container, then the build would fail.
This fixes the specific issue.

The changes along the way are:
a.) builds as 'build-user' rather than 'ubuntu'.
    A consistent distro-nuetral user just seems to make more sense.
b.) build in /home/build-user/buildd rather than /tmp/.
    This seems cleaner as other no other system processes will be
    adding or removing files from that directory.

LP: #1749609

5a9a763... by Kyle Fazzari

Move wrappers out of snap dir

This is not supported by the snapcraft CLI, and leads to odd behavior
that will become more broken with the next release.

Signed-off-by: Kyle Fazzari <email address hidden>