We should also check the length since zip()'s output is the shortest of
its two inputs. This fixes the associated test.
I've also simplified the associated error path code, since I think it's
sufficient to just raise an exception and not swallow it higher up the
stack. Problems with changelog parsing can be reproduced later easily
enough.
We want to make sure that our gnupg binary and libraries are built
before git-ubuntu. In 48249b21607fdfbb80af9d53e8d0b1375d8778c1, the
local build reversion was reverted in turn, but the ordering was missed.
This leads to inconsistent builds.
This message was left behind to avoid a functional change in a previous
refactoring.
Unfortunately it has now become quite disconnected from the
implementation of logic that it is logging. It's at risk of becoming
wrong in the future if the implementation elsewhere is intentionally
changed.
Since it doesn't seem that important, drop it to avoid this happening.
git_repository: add close method and invoke it in a try/finally from importer
Push the ability to remove a repository's directory into the repository
itself and make caller's responsible for the removal.
Wrap importer.main in try/finally, where the finally clause calls
repo.close() directly. This removes our use of atexit, and ensures that
whether import succeeds or fails, the repository object we may have
created is cleaned up per the arguments.
These arguments all correspond to command line options that currently
use 'store_true', so the sensible default for all of them is False.
This does not change behaviour as all existing callers specify the
argument values explicitly, but it will be useful for the introduction
of tests in a future commit which isn't testing the behaviour of all of
these.
