Code review comment for ~racb/git-ubuntu:clone-remote-tracking

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Robie.

A helper or a new function could be extracted from the 2 new test cases (test_create_tracking_branch*) since most of the code in those are duplicated. This shouldn't be a blocker here though since they are short test cases (however, if we ever need to use the same snippets for another test, we should consider extracting that duplicated code snippet somehow).

LGTM

review: Approve

« Back to merge proposal