Merge ~racb/git-ubuntu:cryptography-pin into git-ubuntu:master

[Robie Basak]

Make Jenkins happy

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:0bdaab8685bbdc6240a52ed05ba06fc394a46d3c
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/10/
Executed test runs:
    SUCCESS: VM Setup
    FAILED: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/10//rebuild

review: Needs Fixing (continuous-integration)

[Bryce Harrington (bryce)]

LGTM, and also agree it's better to fix this by updating to a newer ubuntu release than to manually bring in more dependencies.

review: Approve

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:0bdaab8685bbdc6240a52ed05ba06fc394a46d3c
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/11/
Executed test runs:
    SUCCESS: VM Setup
    FAILED: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/11//rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:0bdaab8685bbdc6240a52ed05ba06fc394a46d3c
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/12/
Executed test runs:
    FAILED: VM Setup

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/12//rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:0bdaab8685bbdc6240a52ed05ba06fc394a46d3c
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/13/
Executed test runs:
    SUCCESS: VM Setup
    FAILED: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/13//rebuild

review: Needs Fixing (continuous-integration)

[Robie Basak (racb)]

This MP is no longer necessary since we moved the snap to core20 to base it on Focal. python3-cryptography from Focal is now used, and we rely on Ubuntu's security support for that package. In the case of a future bump to a core22, that Ubuntu release's build of python3-cryptography will be used, which will either already be built with Rust, or use whatever other solution Debian and Ubuntu will have found, and security support will continue through the distribution for us.

Unmerged commits

0bdaab8... by Robie Basak on 2021-02-22

Pin cryptography to avoid Rust

Currently CI is failing because cryptography from PyPI now requires Rust
support to successfully build.

For the time being, we can pin to an older version of cryptography that
still works. This is a workaround, so I've filed LP: #1916520 to track
this.

diff --git a/setup.py b/setup.py
index 8262eed..68ab571 100644
--- a/setup.py
+++ b/setup.py
@@ -27,6 +27,7 @@ setup(name='gitubuntu',
     install_requires=[
         'argcomplete==1.8.1',
         'cachetools',
+        'cryptography<3.4',  # workaround for LP: #1916520
         'python-debian==0.1.31',
         'pygit2==0.24.2',  # see pinning notes above
         'launchpadlib==1.10.6',