I might name the 'changelog_notes' parameter to 'has_changelog_notes' to better communicate that it's a bool rather than e.g. a list of notes or something. But this is internal and well documented so fine if you'd rather keep it as is. Either way, no need for another review round trip.
Otherwise, is a very straightforward fix, and very nice to see the additional code docs.
Looks good.
I might name the 'changelog_notes' parameter to 'has_changelog_ notes' to better communicate that it's a bool rather than e.g. a list of notes or something. But this is internal and well documented so fine if you'd rather keep it as is. Either way, no need for another review round trip.
Otherwise, is a very straightforward fix, and very nice to see the additional code docs.