Merge ~racb/git-ubuntu:pylint-bug-workaround into git-ubuntu:master

Proposed by Robie Basak
Status: Merged
Merged at revision: 7de260e64b0d7ff0eaf8435dc7a812ac9d01915d
Proposed branch: ~racb/git-ubuntu:pylint-bug-workaround
Merge into: git-ubuntu:master
Diff against target: 19 lines (+2/-1)
1 file modified
setup.py (+2/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Bryce Harrington Approve
Paride Legovini (community) Approve
Review via email: mp+374154@code.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

LGTM. I was hoping for a pylint upstream fix, but this doesn't seem to be happening soon enough.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good as a temporary fix to the problem.

Hopefully gives upstream time to work out a proper fix.

Longer term, OddBloke mentioned it doesn't reproduce with python 3.7 so worst case if this never gets addressed, it'll become a non-issue when some day we can move to python 3.7.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:7de260e64b0d7ff0eaf8435dc7a812ac9d01915d
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/372/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/372//rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/setup.py b/setup.py
2index 738e244..5c3ae01 100644
3--- a/setup.py
4+++ b/setup.py
5@@ -15,12 +15,13 @@ setup(name='gitubuntu',
6 maintainer_email="usd-import-team@lists.launchpad.net ",
7 install_requires=[
8 'argcomplete==1.8.1',
9+ 'astroid<2.3', # https://github.com/PyCQA/pylint/issues/3137
10 'cachetools',
11 'python-debian==0.1.31',
12 'pygit2==0.24.2',
13 'launchpadlib==1.10.6',
14 'petname',
15- 'pylint',
16+ 'pylint<2.4', # https://github.com/PyCQA/pylint/issues/3137#issuecomment-542286971
17 'setuptools',
18 'keyring<16', # https://github.com/jaraco/keyrings.alt/issues/28
19 'keyrings.alt',

Subscribers

People subscribed via source and target branches