Code review comment for ~racb/git-ubuntu:importer-cleanup-tmpdir-always

Revision history for this message
Robie Basak (racb) wrote :

> I have just realised that I've obliterated Nish's careful separation of getting a test failing with xfail first. I can restore that separation and rebase tomorrow if needed.

I spent some time this morning looking at doing this, but came to the conclusion that it isn't worth the effort on this occasion. The tests as finally written won't work in that form prior to the refactor. So I'd have to write some other kind of tests (perhaps Nish's original ones) and then change the tests to the new form later.

Having said that, if you'd like it done in that form or another, I can still do it - just let me know.

« Back to merge proposal