Merge lp:~r2d2.art2005/midori/midori into lp:~vcs-imports/midori/master

Proposed by Arturo Torres Sánchez
Status: Merged
Merge reported by: Cris Dywan
Merged at revision: not available
Proposed branch: lp:~r2d2.art2005/midori/midori
Merge into: lp:~vcs-imports/midori/master
Diff against target: 67 lines (+22/-13)
1 file modified
midori/midori-browser.c (+22/-13)
To merge this branch: bzr merge lp:~r2d2.art2005/midori/midori
Reviewer Review Type Date Requested Status
VCS imports Pending
Review via email: mp+145063@code.launchpad.net

Description of the change

This branch fixes bug 1082786

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-browser.c'
2--- midori/midori-browser.c 2013-01-10 22:45:48 +0000
3+++ midori/midori-browser.c 2013-01-26 16:08:19 +0000
4@@ -4909,41 +4909,50 @@
5
6 #ifdef HAVE_GRANITE
7 static void
8-midori_browser_notebook_tab_added_cb (GtkWidget* notebook,
9+midori_browser_notebook_tab_added_cb (GtkWidget* notebook,
10 GraniteWidgetsTab* tab,
11- MidoriBrowser* browser)
12+ MidoriBrowser* browser)
13 {
14+ gint n = granite_widgets_dynamic_notebook_get_tab_position (notebook, tab);
15+ midori_browser_set_current_page (browser, n);
16 GtkWidget* view = midori_view_new_with_item (NULL, browser->settings);
17 midori_view_set_tab (MIDORI_VIEW (view), tab);
18 midori_browser_connect_tab (browser, view);
19+ midori_view_set_uri (MIDORI_VIEW (view), "");
20 /* FIXME: signal add-tab */
21 _midori_browser_update_actions (browser);
22- midori_view_set_uri (MIDORI_VIEW (view), "");
23+ midori_browser_notebook_page_reordered_cb (GTK_WIDGET (notebook),
24+ MIDORI_VIEW (view), n, browser);
25 }
26
27 static gboolean
28-midori_browser_notebook_tab_removed_cb (GtkWidget* notebook,
29+midori_browser_notebook_tab_removed_cb (GtkWidget* notebook,
30 GraniteWidgetsTab* tab,
31- MidoriBrowser* browser)
32+ MidoriBrowser* browser)
33 {
34 MidoriView* view = MIDORI_VIEW (granite_widgets_tab_get_page (tab));
35 if (midori_browser_tab_connected (browser, MIDORI_VIEW (view)))
36 midori_browser_disconnect_tab (browser, MIDORI_VIEW (view));
37+
38+ GraniteWidgetsTab* new_tab = granite_widgets_dynamic_notebook_get_current (
39+ GRANITE_WIDGETS_DYNAMIC_NOTEBOOK (notebook));
40+ gint new_pos = granite_widgets_dynamic_notebook_get_tab_position (notebook, new_tab);
41+ midori_browser_switched_tab (browser, tab,
42+ MIDORI_VIEW (granite_widgets_tab_get_page (new_tab)), new_pos);
43+ gtk_widget_destroy (view);
44 return TRUE;
45 }
46
47 static void
48-midori_browser_move_tab_to_notebook (MidoriBrowser* browser,
49- GtkWidget* view,
50+midori_browser_move_tab_to_notebook (MidoriBrowser* browser,
51+ GtkWidget* view,
52 GraniteWidgetsTab* tab,
53- GtkWidget* new_notebook)
54+ GtkWidget* new_notebook)
55 {
56- g_object_ref (tab);
57- _midori_browser_remove_tab (browser, view);
58- granite_widgets_dynamic_notebook_insert_tab (
59- GRANITE_WIDGETS_DYNAMIC_NOTEBOOK (new_notebook), tab, 0);
60+ gint n = midori_browser_add_uri (midori_browser_get_for_widget (new_notebook), midori_tab_get_uri (MIDORI_TAB (view)));
61+ midori_browser_set_current_page (midori_browser_get_for_widget (new_notebook), n);
62+ midori_view_set_tab (MIDORI_VIEW (view), midori_browser_get_current_tab (midori_browser_get_for_widget (new_notebook)));
63 midori_browser_connect_tab (midori_browser_get_for_widget (new_notebook), view);
64- g_object_unref (tab);
65 }
66
67 static void

Subscribers

People subscribed via source and target branches

to all changes: