Midori Web Browser

address bar shows wrong address after closing tab

Bug #1082786 reported by Jarrod Bagwell
112
This bug affects 22 people
Affects Status Importance Assigned to Milestone
Granite
Invalid
Undecided
Unassigned
Midori Web Browser
Fix Released
Undecided
Julián Unrrein
Midori Web Browser 0.5.3 "Flat Tire Race"

Bug Description

If I have multiple tabs open and I close one of them, the address of the closed tab gets imposed on the next open tab that midori switches to. This imposition is persistent through cycling across a few tabs and can only be fixed by a page refresh or by manually retyping the address of the page that you are actually on.

Related branches

lp:~junrrein/midori/fix-1082786
Cris Dywan: Approve
Diff: 26 lines (+0/-9)
1 file modified
midori/midori-browser.c (+0/-9)
Jarrod Bagwell (jarrodbagwell)
affects: midori → elementaryos
Revision history for this message
Otto Robba (otto-ottorobba) wrote :

Same problem here. Also have it happen sometimes with links I mouse over, they get "stuck" in the adress bar.

Cris Dywan (kalikiana)
tags: added: granite
no longer affects: elementaryos
Changed in midori:
status: New → Confirmed
summary: - Midori's address bar shows the wrong address after closing a tab
+ address bar shows wrong address after closing tab
Revision history for this message
Corentin Noël (tintou) wrote :

see bug #1106018 for a fix

Changed in midori:
assignee: nobody → Corentin Noël (tintou)
Revision history for this message
Arturo Torres Sánchez (r2d2.art2005) wrote :

Corentin, I've applied your changes in my branch
https://code.launchpad.net/~r2d2.art2005/midori/midori
Now all is needed is a merge

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks a lot for the patch Corentin, and Arturo as well. I cleaned up minor type warnings and committed the adding/ removing part.

Revision history for this message
Cris Dywan (kalikiana) wrote :

The moving-related code doesn't work for me at all. I tried to tweak it but Granite's semantics are rather confusing here... a further look would be appreciated, albeit this bug is technically fixed.

Changed in midori:
status: Confirmed → Fix Committed
tags: added: notebook urlbar
Revision history for this message
Arturo Torres Sánchez (r2d2.art2005) wrote :

Reopening because it seems that it wasn't fixed.
Bug 1132005 is duplicate of this.

Changed in midori:
status: Fix Committed → Confirmed
Victor Martinez (victored)
tags: added: dynamic-notebook
removed: notebook
Revision history for this message
Julián Unrrein (junrrein) wrote :

Arturo's fix doesn't work because it assumes that the "tab_removed" signal of DynamicNotebook gets emitted after a tab is removed, which is not the case. See https://bugs.launchpad.net/granite/+bug/1181657.
Trying to get the current tab in that situation will return the tab that is active before the tab is removed.

To handle this event, the "tab_switched" signal should be used instead.

Julián Unrrein (junrrein)
Changed in midori:
assignee: Corentin Noël (tintou) → Julián Unrrein (junrrein)
Julián Unrrein (junrrein)
Changed in granite:
status: New → Invalid
Cris Dywan (kalikiana)
Changed in midori:
milestone: none → 0.5.3-freeze
Julián Unrrein (junrrein)
Changed in midori:
status: Confirmed → In Progress
Cris Dywan (kalikiana)
Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.