Merge ~r00ta/maas:lp-2027625 into maas:master

[Jacopo Rota]

fix bootresource last_deployed property

This MP aims to fix https://bugs.launchpad.net/maas/+bug/2027625. See that bug report for the entire explanation of the problem and the fix.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp-2027625 lp:~r00ta/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/3020/console
COMMIT: b9bc3e01ec39ef3c8e9238223b922691c0b7477e

review: Needs Fixing

[Jacopo Rota (r00ta)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp-2027625 lp:~r00ta/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: b9bc3e01ec39ef3c8e9238223b922691c0b7477e

review: Approve

[Jack Lloyd-Walters (lloydwaltersj)]

+1, nice! optional suggestion inline to remove the `try ... except`.

review: Approve

f38086d... by Jacopo Rota on 2023-07-13

refactoring

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp-2027625 lp:~r00ta/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: f38086dc23297346337cb7b84aede2887f01014e

review: Approve

diff --git a/src/maasserver/models/bootresource.py b/src/maasserver/models/bootresource.py
index 04fb36d..a843d5f 100644
--- a/src/maasserver/models/bootresource.py
+++ b/src/maasserver/models/bootresource.py
@@ -5,6 +5,7 @@
 
 from datetime import datetime
 from operator import attrgetter
+from typing import Optional
 
 from django.core.exceptions import ValidationError
 from django.db.models import (
@@ -671,22 +672,19 @@ class BootResource(CleanSave, TimestampedModel):
                 return resource_set
         return None
 
-    def get_last_deploy(self) -> datetime:
+    def get_last_deploy(self) -> Optional[datetime]:
         from maasserver.models.event import Event
         from provisioningserver.events import EVENT_TYPES
 
-        deploy_msg = f"deployed {self.name}/{self.architecture}"
-        try:
-            return (
-                Event.objects.filter(
-                    type__name=EVENT_TYPES.IMAGE_DEPLOYED,
-                    description=deploy_msg,
-                )
-                .latest("created")
-                .created
-            )
-        except Event.DoesNotExist:
-            pass
+        # Ignore subarch/platform/supported_platforms
+        arch, _ = self.split_arch()
+        deploy_msg_prefix = f"deployed {self.name}/{arch}/"
+        if event := Event.objects.filter(
+            type__name=EVENT_TYPES.IMAGE_DEPLOYED,
+            description__startswith=deploy_msg_prefix,
+        ):
+            return event.latest("created").created
+        return None
 
     def split_arch(self):
         return self.architecture.split("/")
diff --git a/src/maasserver/websockets/handlers/tests/test_bootresource.py b/src/maasserver/websockets/handlers/tests/test_bootresource.py
index 01bda2c..a6c898f 100644
--- a/src/maasserver/websockets/handlers/tests/test_bootresource.py
+++ b/src/maasserver/websockets/handlers/tests/test_bootresource.py
@@ -373,11 +373,12 @@ class TestBootResourcePoll(MAASServerTestCase, PatchOSInfoMixin):
         os_name, series = resource.name.split("/")
         # The polled datetime only has granularity of order seconds
         start_time = datetime.datetime.now().replace(microsecond=0)
+        architecture = BootResource.objects.get_usable_architectures()[0]
         node = factory.make_Node(
             status=NODE_STATUS.DEPLOYED,
             osystem=os_name,
             distro_series=series,
-            architecture=resource.architecture,
+            architecture=architecture,
         )
         node.end_deployment()
         response = handler.poll({})