Code review comment for lp:~qzhang/lava-scheduler/retrieve-job-fail-reason

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Firstly I should apologise; I think I said that I'd look at this weeks ago and haven't.

I definitely like the idea of attempting, even quite crudely, to automatically fish problems out of the log.

I don't think having a static list in the source is a very good way of doing this though -- perhaps we could have a simple table containing regular expressions and explanations that you could edit through the admin interface?

Also, I think if we're going to put more information in the transition table (which sounds fine), we should display it better. We have markdown support in lava-server already so it should be possible to render it as markdown if we really want to... (I also think we should be able to edit the most recent offline reason, but that surely is a separate bug).

« Back to merge proposal