Code review comment for lp:~qzhang/lava-dispatcher/test-abrek

> > > 87 + self.client.run_shell_command(
> > > 88 + 'chroot /mnt/root umount /proc',
> > > 89 + response = master_str)
> > > There's more cleanup you need to do here. You have a bind mount for /dev,
> > and would probably be good to remove /abrek since it was just needed for the
> > install, replace resolv.conf original file,
> > For /dev bind mount, it doesn't help to eliminate the warning message
> > "Can not write log, openpty() failed (/dev/pts not mounted?), does not
> > work" after I tried. Do you have some other way? Or we can ignore it for
> > all seems working.
> The reason is because you used -rbind. You have additional mountpoints,
> probably for shm and pts, under your remounted /dev. If the error doesn't
> cause any problem, I think it's safe to ignore. Otherwise, you'll need to
> either manually mount /dev/pts, and just unmount that when done. Or, you can
> do something like:
> cat /proc/mounts | awk '{print $2}' | grep "^/mnt/root/dev" | sort -r | xargs
> umount

I have fixed "Can not write log, openpty() failed (/dev/pts not mounted?), does not..." warning message by r24, using "mount --rbind /dev /mnt/root/dev", not "chroot /mnt/root mount --rbind /dev /mnt/root/dev".

For the mount occurs in master image, I think we can ignore the umount for /mnt/root/dev.

All the comments are finished.