Code review comment for lp:~qzhang/lava-dispatcher/test-abrek

Revision history for this message
Spring Zhang (qzhang) wrote :

Finish the main command sequences of deploying abrek to test image in a new action cmd_deploy_abrek, and have a test, it can work basically. It's the first part of the whole test_abrek.

In my mind, test_abrek splits to three parts, first is cmd_deploy_abrek, the second is cmd_install_abrek for abrek installing test suites like ltp, the last is cmd_test_abrek to execute real test suite command.

Now I put the cmd_deploy_abrek in abrek.py, do you think I need to move it to deploy.py for it is deployment.

Improvements:
1. stop cron service to avoid libc dialog when installing python-distutils-extra
2. Do I need to verify every command to ensure it succeed? like install bzr
3. does it need to change to a temp path to install abrek? I checkout abrek to / now.
4. does it need to restore old resolv.conf in test image?

Some issues:
1. The commands send to serial get lost some part sometimes, so the command will fail.
2. Can we repeat the action if abrek can't install first time if something wrong.

« Back to merge proposal