Code review comment for lp:~qzhang/lava-dispatcher/fix-network-timeout

Revision history for this message
Paul Larson (pwlars) wrote :

But the problem with this is that for some (most?) people, the board will acquire the address within seconds of booting. Waiting 2 minutes before even trying is going to be annoying, and useless in that case. Looking at the bug, I see 2 things that it seems are happening:
1. you are only getting 4 attempts in the 2 minutes it takes before timing out. This is unusual. How long is each attempt taking? It should probably fail out after a reasonable amount of time. For me, it takes about 3 seconds I think before ping exits if it doesn't get a response, and sometimes immediately depending on the situation. If this isn't happening for you, we should see why, or better yet just add -w5 or something so that it times out after 5 seconds regardless of what it has or hasn't received.
2. It's still not waiting long enough for you. So as I asked in the last merge proposal, how long does it reasonably take on your network, before you can be sure you'll get a response on the address??? I think 2 minutes is a fairly long amount of time, and we've pushed this timeout several times already. I'm tempted to say let's just make it 5 minutes, but I'm worried that still won't be long enough for your situation.

Let's find some reasonable timeout and just be done with this, but don't wait 2 minutes before even checking to see if the network is up.

« Back to merge proposal