Code review comment for lp:~qzhang/lava-dispatcher/fix-network-timeout
Revision history for this message
| Spring Zhang (qzhang) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
> Can you explain more about what you are trying to accomplish here? This patch
> would seem to make it (assuming default timeout of 120 seconds):
> 1. Sleep for 120 seconds
> 2. check to see if the network is up
> 3. repeat #2 until it's up, or until 60 seconds have gone by.
>
> Basically this is just going to cause it to wait 2 minutes before even
> checking to see if the network is alive, then scan it for half that time. I
> don't think that's what we want to do here.
Please see the bug description, I find the timeout way used before can not get the timeout(default 120s) on my board, if the network is not probed up, it will ping several times and fail, but the time is far away reached the timeout. I made a patch to increase the timeout to be 120s, but now I find it can't work, so I think it's better to wait for the timeout(just sleep), and also use a former detection way with a smaller timeout(now I set to half)