Code review comment for lp:~qzhang/lava-dispatcher/fix-861115

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

116 + self.android_result_dir = mkdtemp(dir=LavaClient.lava_result_dir)
117 + os.chmod(self.android_result_dir, 0755)

LavaClient doesn't have property lava_result_dir, it should be self.context.lava_result_dir I think.

btw, about the mode, default is as below, why need to change?

The directory is readable, writable, and searchable only by the creating user.

review: Needs Fixing

« Back to merge proposal