Code review comment for lp:~quickly-committers/quickly/gtk3-projects

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Excellent work Michael! It's even frustrating that I have nothing to say about it as your much as your work there rocks!

Just a small questions though, in the test apport file:
1154 -quickly upgrade 0.3 0.4
1155 +quickly upgrade 0.3
at multiple time, do you need that and why?

However, I get a lot of error in the testsuite here. Seems to be more a setup issue than anything and not really have the time to run it. So if you confirm that all the tests are passing, please, feel free to merge :)

review: Approve

« Back to merge proposal