Code review comment for lp:~quam-plures-core/quam-plures/posting_xhtml-fixes

Revision history for this message
EdB (edb) wrote :

Finally tried a test on this and I don't see where it fails, but I don't see what gain we get from it. Specifically, I tried posting some php code and nothing happened. Which sort of makes sense given that spitting out the item's content is part of what the server does, but it doesn't revisit the content to see if new instructions exist.

<?php echo "http://localhost/branches_from_others/posting_xhtml-fixes/media/blogs/id_1/waterfall.jpg"; ?> doesn't post the image - it just gets ignored.

Adding some text then a comment then some text worked, but each bit of text got wrapped in it's own P tag.

hello world! <!-- this is a comment -->how's it going? created 2 paragraphs is what I mean. I'm not sure that is what a user would expect when adding an inline comment ya know?

As I said I don't see a problem, but I'm also not sure I see the gain. Other than the "shhh!" issue, which clearly needed to be fixed. Can you show me a case where enabling code in posts actually works? Even if it isn't very realistic (like php to pop in an image), just something that shows how it is a gain.

Gonna leave this as a comment instead of approving because I'm a bit worried that somehow we might have bit ourselves in the ass. Hopefully Yabs can look at it from a security angle cuz I pretty much can't. Malicious mean-spirited code is much more a Yabs thing ;) And if Yabs is okay with this branch then I have no objection and will gladly do the merge thing.

« Back to merge proposal