Merge lp:~quam-plures-core/quam-plures/fix_vimeo_issue into lp:quam-plures

Proposed by EdB
Status: Merged
Approved by: Tilman Blumenbach
Approved revision: 7448
Merged at revision: not available
Proposed branch: lp:~quam-plures-core/quam-plures/fix_vimeo_issue
Merge into: lp:quam-plures
Diff against target: 37 lines (+3/-3)
3 files modified
install/_functions_install.php (+1/-1)
plugins/video_plugin/video_modules/_theonion.vp.php (+1/-1)
plugins/video_plugin/video_modules/_vimeo.vp.php (+1/-1)
To merge this branch: bzr merge lp:~quam-plures-core/quam-plures/fix_vimeo_issue
Reviewer Review Type Date Requested Status
Tilman Blumenbach Pending
Review via email: mp+21748@code.launchpad.net

Description of the change

Fixed vimeo so that it renders. Problem was it had a space between W:NNN and X:NNN but did not look for that space when rendering. Solution was to add a space ;) Also replaced 'videoplug' with 'video' in the installer, and replaced a reference to videoplug in 'theonion' video file thing.

And tested it - actually saw it render a vimeo video on localhost !

To post a comment you must log in.
7448. By EdB

implementating qp-bug-543480

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'install/_functions_install.php'
--- install/_functions_install.php 2010-03-12 16:43:42 +0000
+++ install/_functions_install.php 2010-03-22 04:43:25 +0000
@@ -427,7 +427,7 @@
427 install_plugin( 'auto_p_plugin' );427 install_plugin( 'auto_p_plugin' );
428 install_plugin( 'texturize_plugin' );428 install_plugin( 'texturize_plugin' );
429 install_plugin( 'smilies_plugin' );429 install_plugin( 'smilies_plugin' );
430 install_plugin( 'videoplug_plugin' );430 install_plugin( 'video_plugin' );
431 // TemplateTags:431 // TemplateTags:
432 install_plugin( 'calendar_plugin' );432 install_plugin( 'calendar_plugin' );
433 install_plugin( 'archives_plugin' );433 install_plugin( 'archives_plugin' );
434434
=== modified file 'plugins/video_plugin/video_modules/_theonion.vp.php'
--- plugins/video_plugin/video_modules/_theonion.vp.php 2010-03-16 14:39:04 +0000
+++ plugins/video_plugin/video_modules/_theonion.vp.php 2010-03-22 04:43:25 +0000
@@ -1,6 +1,6 @@
1<?php1<?php
2/**2/**
3 * This file implements the TheOnion Video class of the VideoPlug plugin for Quam Plures3 * This file implements the TheOnion Video class of the video plugin for Quam Plures
4 *4 *
5 * Quam Plures - {@link http://quamplures.net/}5 * Quam Plures - {@link http://quamplures.net/}
6 * Released under GNU GPL License - {@link http://quamplures.net/license.html}6 * Released under GNU GPL License - {@link http://quamplures.net/license.html}
77
=== modified file 'plugins/video_plugin/video_modules/_vimeo.vp.php'
--- plugins/video_plugin/video_modules/_vimeo.vp.php 2010-03-18 14:46:33 +0000
+++ plugins/video_plugin/video_modules/_vimeo.vp.php 2010-03-22 04:43:25 +0000
@@ -135,7 +135,7 @@
135 $extras .= '&color=FFFFFF';135 $extras .= '&color=FFFFFF';
136 break;136 break;
137 }137 }
138 $content = preg_replace( '#\[video:vimeo:(.+?) w:(.+?)h:(.+?)]#', '<div class="videoblock"><object type="application/x-shockwave-flash" data="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" [vimeoscale:\\2:\\3]><param name="movie" value="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" /><param name="allowfullscreen" value="true" /><param name="wmode" value="transparent" /></object></div>', $content );138 $content = preg_replace( '#\[video:vimeo:(.+?) w:(.+?) h:(.+?)]#', '<div class="videoblock"><object type="application/x-shockwave-flash" data="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" [vimeoscale:\\2:\\3]><param name="movie" value="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" /><param name="allowfullscreen" value="true" /><param name="wmode" value="transparent" /></object></div>', $content );
139139
140 //@todo yabs > tidy this up140 //@todo yabs > tidy this up
141 $content = preg_replace( '#\[video:vimeo:(.+?)]#', '<div class="videoblock"><object type="application/x-shockwave-flash" data="http://www.vimeo.com/moogaloop.swf?clip_id=$1'.$extras.'" [vimeoscale:400:225]><param name="movie" value="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" /><param name="allowfullscreen" value="true" /><param name="wmode" value="transparent" /></object></div>', $content );141 $content = preg_replace( '#\[video:vimeo:(.+?)]#', '<div class="videoblock"><object type="application/x-shockwave-flash" data="http://www.vimeo.com/moogaloop.swf?clip_id=$1'.$extras.'" [vimeoscale:400:225]><param name="movie" value="http://www.vimeo.com/moogaloop.swf?clip_id=\\1'.$extras.'" /><param name="allowfullscreen" value="true" /><param name="wmode" value="transparent" /></object></div>', $content );

Subscribers

People subscribed via source and target branches