Merge lp:~quadrispro/ubiquity/fix-690912 into lp:ubiquity

Proposed by Alessio Treglia
Status: Merged
Merged at revision: 5269
Proposed branch: lp:~quadrispro/ubiquity/fix-690912
Merge into: lp:ubiquity
Diff against target: 66 lines (+19/-2)
4 files modified
debian/ubiquity.templates (+5/-0)
ubiquity/frontend/base.py (+7/-0)
ubiquity/frontend/gtk_ui.py (+3/-1)
ubiquity/frontend/kde_ui.py (+4/-1)
To merge this branch: bzr merge lp:~quadrispro/ubiquity/fix-690912
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+44052@code.launchpad.net

Description of the change

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/ubiquity.templates'
2--- debian/ubiquity.templates 2010-12-09 12:22:52 +0000
3+++ debian/ubiquity.templates 2010-12-17 14:07:59 +0000
4@@ -885,6 +885,11 @@
5 If you do not go back to the partitioner and increase the size of these
6 partitions, the installation may fail.
7
8+Template: ubiquity/hide_slideshow
9+Type: boolean
10+Default: false
11+Description: for internal use; hide the slideshow while installing.
12+
13 Template: ubiquity/text/oem_user_config_title
14 Type: text
15 _Description: System Configuration
16
17=== modified file 'ubiquity/frontend/base.py'
18--- ubiquity/frontend/base.py 2010-12-16 16:12:36 +0000
19+++ ubiquity/frontend/base.py 2010-12-17 14:07:59 +0000
20@@ -134,6 +134,13 @@
21 except debconf.DebconfError:
22 pass
23
24+ self.hide_slideshow = False
25+ try:
26+ if self.db.get('ubiquity/hide_slideshow') == 'true':
27+ self.hide_slideshow = True
28+ except debconf.DebconfError:
29+ pass
30+
31 # Load plugins
32 plugins = plugin_manager.load_plugins()
33 modules = plugin_manager.order_plugins(plugins)
34
35=== modified file 'ubiquity/frontend/gtk_ui.py'
36--- ubiquity/frontend/gtk_ui.py 2010-12-16 16:12:36 +0000
37+++ ubiquity/frontend/gtk_ui.py 2010-12-17 14:07:59 +0000
38@@ -731,7 +731,9 @@
39
40 #Parse the slideshow size early to prevent the window from growing
41 self.slideshow = '/usr/share/ubiquity-slideshow'
42- if os.path.exists(self.slideshow):
43+ if 'UBIQUITY_AUTOMATIC' in os.environ and self.hide_slideshow == True:
44+ self.slideshow = None
45+ elif os.path.exists(self.slideshow):
46 try:
47 cfg = ConfigParser.ConfigParser()
48 cfg.read(os.path.join(self.slideshow, 'slideshow.conf'))
49
50=== modified file 'ubiquity/frontend/kde_ui.py'
51--- ubiquity/frontend/kde_ui.py 2010-12-16 16:12:36 +0000
52+++ ubiquity/frontend/kde_ui.py 2010-12-17 14:07:59 +0000
53@@ -504,10 +504,13 @@
54
55 def start_slideshow(self):
56 slideshow_dir = '/usr/share/ubiquity-slideshow'
57+ if 'UBIQUITY_AUTOMATIC' in os.environ and self.hide_slideshow == True:
58+ self.slideshow = None
59 slideshow_locale = self.slideshow_get_available_locale(slideshow_dir,
60 self.locale)
61 slideshow_main = slideshow_dir + '/slides/index.html'
62- if not os.path.exists(slideshow_main):
63+ if (not os.path.exists(slideshow_main)) or
64+ ('UBIQUITY_AUTOMATIC' in os.environ and self.hide_slideshow == True):
65 self.ui.pageMode.hide()
66 return
67

Subscribers

People subscribed via source and target branches

to status/vote changes: