Merge lp:~qqworini/ubuntu-rssreader-app/upgrade-framework-dev2 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

[Joey Chan]

ubuntu-sdk-14.10-qml-dev1 now becomes ubuntu-sdk-14.10-qml-dev2

The latest supported framework on the 14.10 images has moved from -dev1 to -dev2, and as such we need to move all the core apps to that new framework before uploading to the store - they get rejected if we try to use the old deprecated frameworks.

[Roman Shchekin (mrqtros)]

Ok

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:252
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/245/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/880
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/880/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-utopic-amd64-ci/24

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/245/rebuild

review: Approve (continuous-integration)

[Alan Pope 🍺🐧🐱 🦄 (popey)]

You made the same mistake I did :)

It says ubuntu-sdk-14.04-qml-dev2 in your patch, but should be ubuntu-sdk-14.10-qml-dev2

review: Needs Fixing

[Joey Chan (qqworini)]

@Alan

I already found my mistake :P

u can check the trunk now, got fixed few minutes ago

review: Approve

[Nicholas Skaggs (nskaggs)]

Still says "framework": "ubuntu-sdk-14.04-qml-dev2"

Needs to be 14.10 ;-) Make sure you push the change too!

review: Needs Fixing

[Joey Chan (qqworini)]

@Nicholas

I have merged another branch with the "14.10" fixed, pls check the trunk :)

[David Planella (dpm)]

Seeing that this got fixed somewhere else, I'll mark this branch as rejected.

review: Disapprove

[Joey Chan (qqworini)]

@David

I got this fixed in another branch, pls check the revision history, no worries :)

[David Planella (dpm)]

On Tue, Jul 8, 2014 at 9:29 AM, Joey Chan <email address hidden> wrote:

> @David
>
> I got this fixed in another branch, pls check the revision history, no
> worries :)
>

Hi Joey, that's exactly why I've marked this branch as Rejected.

Otherwise it would still appear in the list of branches needing review [1].
With more and more contributions, we need to make sure we react to the
reviews and that we keep their status up to date.

Thanks!

Cheers,
David.

[1] http://people.canonical.com/~dpm/core-apps-sponsoring/

> --
>
> https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/upgrade-framework-dev2/+merge/225609
> You are reviewing the proposed merge of
> lp:~qqworini/ubuntu-rssreader-app/upgrade-framework-dev2 into
> lp:ubuntu-rssreader-app.
>

Unmerged revisions

=== modified file 'click/manifest.json.in'
--- click/manifest.json.in	2014-05-02 11:11:06 +0000
+++ click/manifest.json.in	2014-07-04 08:03:03 +0000
@@ -1,6 +1,6 @@
 {
     "description": "Rss Reader application",
-    "framework": "ubuntu-sdk-14.04-qml-dev1",
+    "framework": "ubuntu-sdk-14.04-qml-dev2",
     "hooks": {
         "@APP_NAME@": {
             "apparmor": "apparmor.json",