Merge lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Joey Chan
Status: Merged
Approved by: Roman Shchekin
Approved revision: 247
Merged at revision: 250
Proposed branch: lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 23 lines (+2/-0)
2 files modified
ArticleViewItem.qml (+1/-0)
ShortsTab.qml (+1/-0)
To merge this branch: bzr merge lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+225105@code.launchpad.net

Commit message

fix bug 1335871 & 1335876

Description of the change

fix bug 1335871 & 1335876

Roman said there's another "author" issue from autopilot test, but I can tell that's an error from U1DB, it did not store the latest setting data which cause the autopilot test failed.
So I suggest someone clear all data of Shorts (only needed this time, not every time)

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Trunk is now fixed and working properly. Kicking off a rebuild for this MP which should reflect any issues properly

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Joey Chan (qqworini) wrote :

lol

THX !

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ArticleViewItem.qml'
--- ArticleViewItem.qml 2014-05-14 05:28:12 +0000
+++ ArticleViewItem.qml 2014-07-01 03:45:26 +0000
@@ -191,6 +191,7 @@
191 anchors.horizontalCenter: parent.horizontalCenter191 anchors.horizontalCenter: parent.horizontalCenter
192 width: parent.width - units.gu(4)192 width: parent.width - units.gu(4)
193 wrapMode: Text.WrapAtWordBoundaryOrAnywhere193 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
194 visible: text !== "" && text !== '""'
194 }195 }
195196
196 Label {197 Label {
197198
=== modified file 'ShortsTab.qml'
--- ShortsTab.qml 2014-04-30 17:33:12 +0000
+++ ShortsTab.qml 2014-07-01 03:45:26 +0000
@@ -155,6 +155,7 @@
155 "title" : cart.title,155 "title" : cart.title,
156 "content" : cart.content,156 "content" : cart.content,
157 "link" : cart.link,157 "link" : cart.link,
158 "author": cart.author,
158 "description" : cart.description,159 "description" : cart.description,
159 "pubdate" : cart.pubdate,160 "pubdate" : cart.pubdate,
160 "status" : cart.status,161 "status" : cart.status,

Subscribers

People subscribed via source and target branches