Code review comment for lp:~qqworini/ubuntu-rssreader-app/database_v1

Revision history for this message
Joey Chan (qqworini) wrote :

> I think that we shouldn't use separate table for settings because of
> QSettings.
> Maybe Guys from Toolkit team will provide its functionality in QML?
>
> And only for Joey - I agree with your advice (using object instead of variable
> args), but why you are not used this technique in function
> function addArticle(title, link, description, pubdate, guid, feed_id)
> with huge amout of args? :)
> Mb better will be
> function addArticle(title, articleObj)

1. of course qsetting is better, setting table will be replaced if qsetting port to qml;
2. using object instead of variable args, this is a solution for function overload or unknown args' length, in function "addArticle", all args are fixed, no need to use obj;
besides, you can find many "update" functions for every table, like feed and article, I've tried to use obj to make those functions overload, but later I found this is not optimised, because some functions like "updateArticleStatus", it's much high frequency use than other functions. So finally I decided to separate them instead of "overload" them

« Back to merge proposal