Code review comment for lp:~qqworini/ubuntu-rssreader-app/database_v1

Revision history for this message
Roman Shchekin (mrqtros) wrote :

I think that we shouldn't use separate table for settings because of QSettings.
Maybe Guys from Toolkit team will provide its functionality in QML?

And only for Joey - I agree with your advice (using object instead of variable args), but why you are not used this technique in function
function addArticle(title, link, description, pubdate, guid, feed_id)
with huge amout of args? :)
Mb better will be
function addArticle(title, articleObj)

« Back to merge proposal