Code review comment for lp:~qqworini/ubuntu-rssreader-app/database-bug-fixed

Revision history for this message
Roman Shchekin (mrqtros) wrote :

Joey, I found some issues in your code, I will explain them later, when I'll have access to PC.

But in the same time I found good solutions, like json.stringify and so on. We must merge our implementations of addArticles to get best one.

19.06.13 11:52 Joey Chan написал(а):

Joey Chan has proposed merging lp:~qqworini/ubuntu-rssreader-app/database-bug-fixed into lp:ubuntu-rssreader-app.

Commit message:
bugs fixed, especially add a function "addArticles" to avoid the hard drive performance issue

Requested reviews:
Ubuntu RSS Feed Reader Developers (ubuntu-rssreader-dev)

For more details, see:

https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/database-bug-fixed/+merge/170257

bugs fixed, especially add a function "addArticles" to avoid the hard drive performance issue

--
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/database-bug-fixed/+merge/170257

Your team Ubuntu RSS Feed Reader Developers is requested to review the proposed merge of lp:~qqworini/ubuntu-rssreader-app/database-bug-fixed into lp:ubuntu-rssreader-app.

« Back to merge proposal