Code review comment for lp:~qcumber-some/widelands/bugfix-768854

Revision history for this message
SirVer (sirver) wrote :

>> This will break the game logic when a player saves a game, switches locale and
>> reloads. Even worse: when someone attaches a savegame to a bug we need to load
>> it with the same locale or the logic fails. This needs fixing.
>
>This also made me sceptical when I encountered that, but I couldn't pinpoint why, so I left it the way it was, because this already had been the way before, hasn't it?
>
>This is the line you mentioned before my fix:
>
>if candidateisteam and currentcandidate == _("Team %i"):format(p.team)
>
>Isn't this the same problem? If so, I'd vote for keeping my changes to fix this bug and create a new bug addressing game logic breakage. I suspect I'm not fit enough in Lua to fix this.

Yes that is the very same problem. This should not have slipped by :/.
I agree then, a bug report of its own is the way to go. I will merge
your work soonish (maybe tomorrow).

« Back to merge proposal