Code review comment for lp:~qcumber-some/widelands/bugfix-768854

Revision history for this message
Jens Beyer (qcumber-some) wrote :

> I think this solution is dangerous. What it does is changing the textdomain
> which will persist for all other lua functions called later on. This could
> mean that some other text is then not translated. I suggest moving all static
> text out of the inner functions into the global lua namespace so that there
> are translated only once on loading. This is similar to how it is done in the
> scenarios (where we often have a text.lua script that contains all the static
> text).
>
> Could you try that out Jens?

Fixed as requested. From what I found this works, hope I understood correctly what to do ;-)

Please review again.

« Back to merge proposal